[libcxx-commits] [libcxx] [libc++][mdspan] Fix layout_stride->layout_right test (PR #191611)

via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 11 01:17:08 PDT 2026


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: eiytoq (eiytoq)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/191611.diff


1 Files Affected:

- (modified) libcxx/test/std/containers/views/mdspan/layout_right/ctor.layout_stride.pass.cpp (+4-4) 


``````````diff
diff --git a/libcxx/test/std/containers/views/mdspan/layout_right/ctor.layout_stride.pass.cpp b/libcxx/test/std/containers/views/mdspan/layout_right/ctor.layout_stride.pass.cpp
index 5886eba9d15ee..02fedecee7f58 100644
--- a/libcxx/test/std/containers/views/mdspan/layout_right/ctor.layout_stride.pass.cpp
+++ b/libcxx/test/std/containers/views/mdspan/layout_right/ctor.layout_stride.pass.cpp
@@ -33,13 +33,13 @@
 
 template <bool implicit, class ToE, class FromE>
 constexpr void test_conversion(FromE src_exts) {
-  using To   = std::layout_left::mapping<ToE>;
+  using To   = std::layout_right::mapping<ToE>;
   using From = std::layout_stride::mapping<FromE>;
   std::array<typename FromE::index_type, FromE::rank()> strides;
   if constexpr (FromE::rank() > 0) {
-    strides[0] = 1;
-    for (size_t r = 1; r < FromE::rank(); r++)
-      strides[r] = src_exts.extent(r - 1) * strides[r - 1];
+    strides[FromE::rank() - 1] = 1;
+    for (size_t r = FromE::rank() - 1; r > 0; --r)
+      strides[r - 1] = src_exts.extent(r) * strides[r];
   }
   From src(src_exts, strides);
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/191611


More information about the libcxx-commits mailing list