[libcxx-commits] [libcxx] [llvm] [libc++] Optionally support filecheck and split-file (PR #165769)

[Louis Dionne via libcxx-commits]

================
@@ -0,0 +1,16 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// REQUIRES: has-filecheck
+
+// Make sure that FileCheck fails when it should fail. This ensure that FileCheck
+// actually checks the content of the file.
+// XFAIL: *
----------------
ldionne wrote:

Yeah, that's a lot better. I think I used `XFAIL: *` because I copied from another test under `selftest` where using XFAIL is the only way to check. But here `not` is what we should be using.

https://github.com/llvm/llvm-project/pull/165769