[libcxx-commits] [libcxx] [libc++][ranges][NFC] Format a couple of tests as a prerequisite (PR #190514)
via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Apr 5 05:21:30 PDT 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Hristo Hristov (H-G-Hristov)
<details>
<summary>Changes</summary>
to https://llvm.org/PR190513 to avoid friction.
---
Full diff: https://github.com/llvm/llvm-project/pull/190514.diff
2 Files Affected:
- (modified) libcxx/test/std/ranges/range.adaptors/range.filter/ctor.view_pred.pass.cpp (+2-2)
- (modified) libcxx/test/std/ranges/range.adaptors/range.lazy.split/ctor.view.pass.cpp (+6-9)
``````````diff
diff --git a/libcxx/test/std/ranges/range.adaptors/range.filter/ctor.view_pred.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.filter/ctor.view_pred.pass.cpp
index 3ccab93397147..8eaf6eba35709 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.filter/ctor.view_pred.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.filter/ctor.view_pred.pass.cpp
@@ -19,7 +19,7 @@
#include "types.h"
struct Range : std::ranges::view_base {
- constexpr explicit Range(int* b, int* e) : begin_(b), end_(e) { }
+ constexpr explicit Range(int* b, int* e) : begin_(b), end_(e) {}
constexpr int* begin() const { return begin_; }
constexpr int* end() const { return end_; }
@@ -52,7 +52,7 @@ static_assert(!test_convertible<std::ranges::filter_view<Range, Pred>, Range, Pr
#else
-static_assert( test_convertible<std::ranges::filter_view<Range, Pred>, Range, Pred>(),
+static_assert(test_convertible<std::ranges::filter_view<Range, Pred>, Range, Pred>(),
"This constructor must not be explicit");
#endif // TEST_STD_VER >= 23
diff --git a/libcxx/test/std/ranges/range.adaptors/range.lazy.split/ctor.view.pass.cpp b/libcxx/test/std/ranges/range.adaptors/range.lazy.split/ctor.view.pass.cpp
index e7bf052a7e9ee..46af5498d59a0 100644
--- a/libcxx/test/std/ranges/range.adaptors/range.lazy.split/ctor.view.pass.cpp
+++ b/libcxx/test/std/ranges/range.adaptors/range.lazy.split/ctor.view.pass.cpp
@@ -20,18 +20,15 @@
struct ViewWithCounting : std::ranges::view_base {
int* times_copied = nullptr;
- int* times_moved = nullptr;
+ int* times_moved = nullptr;
constexpr ViewWithCounting(int& copies_ctr, int& moves_ctr) : times_copied(&copies_ctr), times_moved(&moves_ctr) {}
constexpr ViewWithCounting(const ViewWithCounting& rhs)
- : times_copied(rhs.times_copied)
- , times_moved(rhs.times_moved) {
+ : times_copied(rhs.times_copied), times_moved(rhs.times_moved) {
++(*times_copied);
}
- constexpr ViewWithCounting(ViewWithCounting&& rhs)
- : times_copied(rhs.times_copied)
- , times_moved(rhs.times_moved) {
+ constexpr ViewWithCounting(ViewWithCounting&& rhs) : times_copied(rhs.times_copied), times_moved(rhs.times_moved) {
++(*times_moved);
}
@@ -39,14 +36,14 @@ struct ViewWithCounting : std::ranges::view_base {
constexpr const char* end() const { return nullptr; }
constexpr ViewWithCounting& operator=(const ViewWithCounting&) = default;
- constexpr ViewWithCounting& operator=(ViewWithCounting&&) = default;
+ constexpr ViewWithCounting& operator=(ViewWithCounting&&) = default;
constexpr bool operator==(const ViewWithCounting&) const { return true; }
};
static_assert(std::ranges::forward_range<ViewWithCounting>);
static_assert(std::ranges::view<ViewWithCounting>);
-using View = ViewWithCounting;
+using View = ViewWithCounting;
using Pattern = ViewWithCounting;
// SFINAE tests.
@@ -58,7 +55,7 @@ static_assert(!test_convertible<std::ranges::lazy_split_view<View, Pattern>, Vie
#else
-static_assert( test_convertible<std::ranges::lazy_split_view<View, Pattern>, View, Pattern>(),
+static_assert(test_convertible<std::ranges::lazy_split_view<View, Pattern>, View, Pattern>(),
"This constructor must not be explicit");
#endif // TEST_STD_VER >= 23
``````````
</details>
https://github.com/llvm/llvm-project/pull/190514
More information about the libcxx-commits
mailing list