[libcxx-commits] [libcxx] [libc++] Optimize __tree::__copy_construct_tree further (PR #161165)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 29 03:05:51 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions  -- libcxx/include/__tree
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/include/__tree b/libcxx/include/__tree
index 0660e9005..336ecf5dd 100644
--- a/libcxx/include/__tree
+++ b/libcxx/include/__tree
@@ -1349,8 +1349,7 @@ private:
 #ifdef _LIBCPP_COMPILER_CLANG_BASED // FIXME: GCC complains about not being able to always_inline a recursive function
   _LIBCPP_HIDE_FROM_ABI
 #endif
-  __node_pointer
-  __copy_construct_tree_impl(__node_pointer __src) {
+  __node_pointer __copy_construct_tree_impl(__node_pointer __src) {
     __node_holder __new_node = __construct_node(__src->__get_value());
 
     unique_ptr<__node, __tree_deleter> __left(

``````````

</details>


https://github.com/llvm/llvm-project/pull/161165


More information about the libcxx-commits mailing list