[libcxx-commits] [libcxx] Revert "[libc++] Avoid constructing additional objects when using map::at" (PR #160738)

[Andrew Lazarev via libcxx-commits]

alazarev wrote:

> > I'm not an expert in RDF.
> > https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy clearly indicates: "If you break a buildbot in a way which can’t be quickly fixed, please revert."
> 
> Yes. However, the document is just as clear that there has to be a way forward for the original patch, which is unfortunately overlooked too often: "It is not considered reasonable to revert without at least the promise to provide a means for the patch author to debug the root issue.". I don't see that here so far given that I don't even have a contact to ask for further information so far (I assume, given your statement above: "I'm not an expert in RDF").

The quote you mentioned is about situations when the revert reason is hard to reproduce. In this particular case there are clear steps to debug. Repro steps can be taken from any of the broken buildbots.

And there is a clear way forward for the original patch: fix problematic components (either by working with code owners or yourself) and re-apply the patch. It can be done AFTER the test infrastructure is restored.

https://github.com/llvm/llvm-project/pull/160738