[libcxx-commits] [libcxx] [libc++] Use _BitInt and __builtin_popcountg in bitset::count() (PR #160679)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 25 05:24:57 PDT 2025


================
@@ -867,7 +867,14 @@ bitset<_Size>::to_string(char __zero, char __one) const {
 
 template <size_t _Size>
 inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX23 size_t bitset<_Size>::count() const _NOEXCEPT {
-  return static_cast<size_t>(std::count(__base::__make_iter(0), __base::__make_iter(_Size), true));
+#ifdef _LIBCPP_COMPILER_CLANG_BASED
+  if constexpr (_Size <= __base::__bits_per_word) {
+    return __builtin_popcountg(static_cast<unsigned _BitInt(_Size)>(__base::__first_));
+  } else
+#endif
+  {
+    return static_cast<size_t>(std::count(__base::__make_iter(0), __base::__make_iter(_Size), true));
----------------
ldionne wrote:

Instead, could we detect that we know `last - first` at compile-time and perform this optimization from `std::cout`? I guess that would require special casing on whether the value we're searching for is `true` or `false`, but that might make sense.

https://github.com/llvm/llvm-project/pull/160679


More information about the libcxx-commits mailing list