[libcxx-commits] [libcxx] 32ff987 - [libc++] Remove outdated FIXME comment in ctype<char> (#160008)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 23 04:51:40 PDT 2025


Author: Fady Farag
Date: 2025-09-23T13:51:36+02:00
New Revision: 32ff98726b563bb6b0da99a9d0a61c6b37e5af73

URL: https://github.com/llvm/llvm-project/commit/32ff98726b563bb6b0da99a9d0a61c6b37e5af73
DIFF: https://github.com/llvm/llvm-project/commit/32ff98726b563bb6b0da99a9d0a61c6b37e5af73.diff

LOG: [libc++] Remove outdated FIXME comment in ctype<char> (#160008)

The FIXME comment about not hardcoding table_size is unclear about its
original intent.

Added: 
    

Modified: 
    libcxx/include/__cxx03/__locale
    libcxx/include/__locale

Removed: 
    


################################################################################
diff  --git a/libcxx/include/__cxx03/__locale b/libcxx/include/__cxx03/__locale
index 86160bcdcbd59..70dd1e65cfba9 100644
--- a/libcxx/include/__cxx03/__locale
+++ b/libcxx/include/__cxx03/__locale
@@ -578,7 +578,7 @@ public:
 #ifdef _CACHED_RUNES
   static const size_t table_size = _CACHED_RUNES;
 #else
-  static const size_t table_size = 256; // FIXME: Don't hardcode this.
+  static const size_t table_size = 256;
 #endif
   _LIBCPP_HIDE_FROM_ABI const mask* table() const _NOEXCEPT { return __tab_; }
   static const mask* classic_table() _NOEXCEPT;

diff  --git a/libcxx/include/__locale b/libcxx/include/__locale
index 757a53951f66e..eb7b7786208e8 100644
--- a/libcxx/include/__locale
+++ b/libcxx/include/__locale
@@ -585,7 +585,7 @@ public:
 #  ifdef _CACHED_RUNES
   static const size_t table_size = _CACHED_RUNES;
 #  else
-  static const size_t table_size = 256; // FIXME: Don't hardcode this.
+  static const size_t table_size = 256;
 #  endif
   _LIBCPP_HIDE_FROM_ABI const mask* table() const _NOEXCEPT { return __tab_; }
   static const mask* classic_table() _NOEXCEPT;


        


More information about the libcxx-commits mailing list