[libcxx-commits] [libcxx] [libc++] XFAIL regex tests that are currently failing on macOS (PR #159260)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 18 00:37:27 PDT 2025


https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/159260

>From 35e4c45031e63f92450533e05912a60a829e4d86 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser <nikolasklauser at berlin.de>
Date: Wed, 17 Sep 2025 09:04:49 +0200
Subject: [PATCH] [libc++] XFAIL regex tests that are currently failing on
 macOS

---
 libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp       | 1 +
 libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp     | 1 +
 libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp      | 1 +
 libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp  | 1 +
 libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp      | 1 +
 libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp    | 1 +
 libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp     | 1 +
 libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp | 1 +
 libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp         | 1 +
 9 files changed, 9 insertions(+)

diff --git a/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp
index 151c9160b0fee..8c2875de01c52 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp
@@ -20,6 +20,7 @@
 // TODO(netbsd): incomplete support for locales
 // XFAIL: target={{.*}}-linux-gnu{{.*}}, netbsd, freebsd
 // XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
 // REQUIRES: locale.cs_CZ.ISO8859-2
 
 #include <regex>
diff --git a/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp
index 463d0fd3bd1eb..9002681547b8d 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp
@@ -24,6 +24,7 @@
 // TODO: investigation needed
 // XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
 // XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
 
 #include <regex>
 #include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp
index b83bfabfb96be..2e6f7fd285ae4 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp
@@ -24,6 +24,7 @@
 // TODO: investigation needed
 // XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
 // XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
 
 #include <regex>
 #include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp
index 24c38e9f631c9..4948f68f3934c 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp
@@ -24,6 +24,7 @@
 // TODO: investigation needed
 // XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
 // XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
 
 #include <regex>
 #include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp
index 3a0229ec3be2f..4c883a1cf380f 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp
@@ -24,6 +24,7 @@
 // TODO: investigation needed
 // XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
 // XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
 
 #include <regex>
 #include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp
index eba6b3383059a..7bf28a27ea604 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp
@@ -24,6 +24,7 @@
 // TODO: investigation needed
 // XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
 // XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
 
 #include <regex>
 #include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp
index 175a05a9ef7c4..64365932bfe72 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp
@@ -24,6 +24,7 @@
 // TODO: investigation needed
 // XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
 // XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
 
 #include <regex>
 #include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp
index e7dbccd6f0ba4..22a98c601de5a 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp
@@ -24,6 +24,7 @@
 // TODO: investigation needed
 // XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
 // XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
 
 #include <regex>
 #include <cassert>
diff --git a/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp b/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp
index 803d062693c33..50434832ddfff 100644
--- a/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp
+++ b/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp
@@ -25,6 +25,7 @@
 // TODO: investigation needed
 // XFAIL: target={{.*}}-linux-gnu{{.*}}
 // XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
 
 #include <regex>
 #include <iterator>



More information about the libcxx-commits mailing list