[libcxx-commits] [libcxx] a41660a - [libc++] Don't run multithreaded stringstream benchmarks (#158294)
via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Sep 15 05:47:44 PDT 2025
Author: Louis Dionne
Date: 2025-09-15T08:47:40-04:00
New Revision: a41660aaf40b0f3b119300a8d980be52c2c4feed
URL: https://github.com/llvm/llvm-project/commit/a41660aaf40b0f3b119300a8d980be52c2c4feed
DIFF: https://github.com/llvm/llvm-project/commit/a41660aaf40b0f3b119300a8d980be52c2c4feed.diff
LOG: [libc++] Don't run multithreaded stringstream benchmarks (#158294)
This results in invalid JSON output as reported in google/benchmark#2039.
Added:
Modified:
libcxx/test/benchmarks/stringstream.bench.cpp
Removed:
################################################################################
diff --git a/libcxx/test/benchmarks/stringstream.bench.cpp b/libcxx/test/benchmarks/stringstream.bench.cpp
index b7c50a96ef51e..367024c49ac69 100644
--- a/libcxx/test/benchmarks/stringstream.bench.cpp
+++ b/libcxx/test/benchmarks/stringstream.bench.cpp
@@ -80,7 +80,7 @@ static void BM_Istream_numbers(benchmark::State& state) {
while (state.KeepRunning())
benchmark::DoNotOptimize(i += istream_numbers(sel.imbue));
}
-BENCHMARK(BM_Istream_numbers)->DenseRange(0, 3)->UseRealTime()->Threads(1)->ThreadPerCpu();
+BENCHMARK(BM_Istream_numbers)->DenseRange(0, 3);
static void BM_Ostream_number(benchmark::State& state) {
LocaleSelector sel(state);
@@ -92,6 +92,6 @@ static void BM_Ostream_number(benchmark::State& state) {
benchmark::DoNotOptimize(ss.str().c_str());
}
}
-BENCHMARK(BM_Ostream_number)->DenseRange(0, 3)->UseRealTime()->Threads(1)->ThreadPerCpu();
+BENCHMARK(BM_Ostream_number)->DenseRange(0, 3);
BENCHMARK_MAIN();
More information about the libcxx-commits
mailing list