[libcxx-commits] [libcxx] [libc++][test] update `MinSequenceContainer.h` to make one more test pass on MSVC STL (PR #158344)

A. Jiang via libcxx-commits libcxx-commits at lists.llvm.org
Fri Sep 12 22:27:34 PDT 2025


================
@@ -29,13 +29,23 @@ struct MinSequenceContainer {
   template <class It>
   explicit TEST_CONSTEXPR_CXX20 MinSequenceContainer(It first, It last) : data_(first, last) {}
   TEST_CONSTEXPR_CXX20 MinSequenceContainer(std::initializer_list<T> il) : data_(il) {}
+  template <class Range>
+  TEST_CONSTEXPR_CXX20 MinSequenceContainer(std::from_range_t, Range&& rg)
+      : data_(std::from_range, std::forward<Range>(rg)) {}
----------------
frederick-vs-ja wrote:

It seems to me that this should be guard with `TEST_STD_VER >= 23` and unconditionally `constexpr`. Ditto `assign_range`.

No change requested as there's no new error, and perhaps we can do clean-up in the future. CI failures are unrelated.

https://github.com/llvm/llvm-project/pull/158344


More information about the libcxx-commits mailing list