[libcxx-commits] [libcxx] [libc++] Refactor vector's ASan annotations to only ever delete and add the annotations (PR #152967)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne approved this pull request.

This LGTM. I like the simplification and the correctness fixes in the case of exceptions being thrown.

The commit message should mention that we technically decrease ASAN coverage *while* we're creating a new element, but I think that's the right tradeoff to keep the code correct and simpler.

Also, let's run the benchmarks. This touches enough important stuff that I wouldn't be surprised to see swings.

https://github.com/llvm/llvm-project/pull/152967