[libcxx-commits] [libcxx] [libc++] Conditionally declare `lgamma_r` as noexcept (PR #156547)

[Joseph Huber via libcxx-commits]

jhuber6 wrote:

> > This broke the libc version of the build, works if I delete that new macro that was added. I'm confused how this works, since AFAICT a macro won't expand another macro when used in and `_NOEXCEPT` isn't a standard term as far as I'm aware, so doesn't this just expand to text? Am I missing something?
> 
> This should expand normally. Could you provide the diagnostic?
> 
> FWIW IMO this has been landed way too eagerly. There hasn't been any more discussion on the other thread so far and this patch has been landed with me opposing it. There was literally no time for me to respond. I'm not a huge fan of changing things without any sort of CI testing for the configuration that is "fixed". OTOH this would have been caught if we had LLVM libc CI coverage, so please make sure to provide that ASAP.

Yeah, I need to get one of the builders updated so it actually hits this path when building at least.

https://github.com/llvm/llvm-project/pull/156547