[libcxx-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (PR #143230)

Daniil Kovalev via libcxx-commits libcxx-commits at lists.llvm.org
Wed Sep 3 05:16:15 PDT 2025


================
@@ -16,6 +16,12 @@
 #include <ptrauth.h>
 #endif
 
+#if __has_feature(ptrauth_calls) || defined(__PTRAUTH__)
----------------
kovdan01 wrote:

It's probably worth submitting changes related to `__PTRAUTH__` introduced in #153912 as a separate PR while keeping this PR only focused on unwind hardening. There are several reasons for keeping such kind of changes separate from each other.

1. The scope of the unwinding-related changes is already pretty wide, and cluttering them with unrelated fixes makes things harder to understand.
2. The unwinding patch is non-trivial and might take noticeable time for review while these unrelated fixes are more or less trivial and might be merged much sooner if submitted separately.
3. Just in case we need to revert this PR due to some issues after it becomes merged, it's better to only revert unwind-related changes while keeping other unrelated fixes merged.

https://github.com/llvm/llvm-project/pull/143230


More information about the libcxx-commits mailing list