[libcxx-commits] [libcxx] [libc++][test][NFC] Clang-format `<regex>` tests (PR #164367)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> @philnik777 Really, we should be formatting the whole code base. It's just that the patch that does that is going to be humongous, not even reviewable on Github. There's too much code.
> 
> As a result, we've been reformatting smaller bits and pieces from time to time, and I think that's acceptable, if done as their own separate patch (which can then be added to `.git-blame-ignore-revs`).

I don't disagree. I do think that we should require a clear intent to modify the code in the near future though. Otherwise there isn't much of a difference between a single patch and someone feeling like formatting entire test suite. "There might be a patch at some point in the future modifying this code" IMO doesn't reach the bar of "this is reasonable to format". Re. the Container formatting, I can't remember what went on in February, so with the current information I have I don't think it was a good idea. If we were actually modifying a significant amount of tests then sure - if we only modified one or two of the tests then IMO it was too broad of a formatting. I'm not convinced that we got anywhere near modifying 1300 tests - an NFC patch to format the tests that we were actually modifying would have been the better alternative IMO.

https://github.com/llvm/llvm-project/pull/164367