[libcxx-commits] [libcxx] [libc++] Improve performance of std::atomic_flag on Windows (PR #163524)

[via libcxx-commits]

================
@@ -101,6 +105,46 @@ static void __libcpp_platform_wake_by_address(__cxx_atomic_contention_t const vo
   _umtx_op(const_cast<__cxx_atomic_contention_t*>(__ptr), UMTX_OP_WAKE, __notify_one ? 1 : INT_MAX, nullptr, nullptr);
 }
 
+#elif defined(_WIN32)
+
+static void
+__libcpp_platform_wait_on_address(__cxx_atomic_contention_t const volatile* __ptr, __cxx_contention_t __val) {
+  // WaitOnAddress was added in Windows 8 (build 9200)
+  static auto wait_on_address = reinterpret_cast<BOOL(WINAPI*)(volatile void*, PVOID, SIZE_T, DWORD)>(
+      GetProcAddress(GetModuleHandleW(L"api-ms-win-core-synch-l1-2-0.dll"), "WaitOnAddress"));
----------------
Alcaro wrote:

Is GetModuleHandle the correct function here? It will return null if that DLL isn't already in the process.

Y'all know more about Windows than me, so if you've found a guarantee that this DLL is already in the process, then I'll trust that. But if so, I feel it deserves a comment.

Alternatively, it can be changed to LoadLibrary. (Probably without worrying about leaking the DLL handle - chances are good it's already needed by something else, and even if not, it's not big.)

https://github.com/llvm/llvm-project/pull/163524