[libcxx-commits] [libcxx] [libcxx] implement LWG4148: unique_ptr::operator* should not allow dangling references (PR #128213)

[Hristo Hristov via libcxx-commits]

Zingam wrote:

> @Zingam @H-G-Hristov @mordante any hint why this fails?

  # |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/libcxx/test/libcxx/memory/unique_ptr.verify.cpp Line 25: unused variable 'i'

You need to `(void)`, `[[maybe_unused]]`, `std::ignore` unused stuff. 

Since Clang19 support should be dropped in libc++ in LLVM22, my personal opinion is to wait it out for the CI to be updated before proceeding with this patch. We won't need all the workarounds.

https://github.com/llvm/llvm-project/pull/128213