[libcxx-commits] [libcxx] [libc+][stack] P3372R3: `constexpr <stack>` (PR #163510)
via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Oct 14 23:39:25 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions ,cpp -- libcxx/include/stack libcxx/test/std/containers/container.adaptors/stack/compare.three_way.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.cons/ctor_default.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.defn/emplace.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.defn/empty.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.defn/pop.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.defn/push.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.defn/push_range.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.defn/push_rv.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.defn/size.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.defn/swap.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.defn/top.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.defn/top_const.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.ops/eq.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.ops/lt.pass.cpp libcxx/test/std/containers/container.adaptors/stack/stack.special/swap.pass.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/libcxx/include/stack b/libcxx/include/stack
index 52910e645..e6ea58c04 100644
--- a/libcxx/include/stack
+++ b/libcxx/include/stack
@@ -184,8 +184,8 @@ public:
}
# ifndef _LIBCPP_CXX03_LANG
- _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX26
- stack(stack&& __q) noexcept(is_nothrow_move_constructible<container_type>::value)
+ _LIBCPP_HIDE_FROM_ABI
+ _LIBCPP_CONSTEXPR_SINCE_CXX26 stack(stack&& __q) noexcept(is_nothrow_move_constructible<container_type>::value)
: c(std::move(__q.c)) {}
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX26 stack&
@@ -338,8 +338,8 @@ stack(from_range_t, _Range&&, _Alloc)
# endif
template <class _Tp, class _Container>
-inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX26 bool
-operator==(const stack<_Tp, _Container>& __x, const stack<_Tp, _Container>& __y) {
+inline _LIBCPP_HIDE_FROM_ABI
+_LIBCPP_CONSTEXPR_SINCE_CXX26 bool operator==(const stack<_Tp, _Container>& __x, const stack<_Tp, _Container>& __y) {
return __x.c == __y.c;
}
diff --git a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/emplace.pass.cpp b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/emplace.pass.cpp
index 5c72bea46..4e85b0dad 100644
--- a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/emplace.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/emplace.pass.cpp
@@ -68,4 +68,3 @@ int main(int, char**) {
return 0;
}
-
diff --git a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/empty.pass.cpp b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/empty.pass.cpp
index 0c8efee1e..fabaec724 100644
--- a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/empty.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/empty.pass.cpp
@@ -34,4 +34,3 @@ int main(int, char**) {
return 0;
}
-
diff --git a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/push_range.pass.cpp b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/push_range.pass.cpp
index 1e9274d47..aac3e7e3c 100644
--- a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/push_range.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/push_range.pass.cpp
@@ -40,4 +40,3 @@ int main(int, char**) {
return 0;
}
-
diff --git a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/push_rv.pass.cpp b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/push_rv.pass.cpp
index 35cdcc150..f29a847a4 100644
--- a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/push_rv.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/push_rv.pass.cpp
@@ -41,4 +41,3 @@ int main(int, char**) {
return 0;
}
-
diff --git a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/size.pass.cpp b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/size.pass.cpp
index 3f4db9bc1..954696dcb 100644
--- a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/size.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/size.pass.cpp
@@ -32,4 +32,3 @@ int main(int, char**) {
return 0;
}
-
diff --git a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/swap.pass.cpp b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/swap.pass.cpp
index d17876605..efff82379 100644
--- a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/swap.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/swap.pass.cpp
@@ -43,4 +43,3 @@ int main(int, char**) {
return 0;
}
-
diff --git a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/top.pass.cpp b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/top.pass.cpp
index 272e77114..992dcdbef 100644
--- a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/top.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/top.pass.cpp
@@ -35,4 +35,3 @@ int main(int, char**) {
return 0;
}
-
diff --git a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/top_const.pass.cpp b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/top_const.pass.cpp
index 8a847cfef..09d950b0d 100644
--- a/libcxx/test/std/containers/container.adaptors/stack/stack.defn/top_const.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/stack/stack.defn/top_const.pass.cpp
@@ -36,4 +36,3 @@ int main(int, char**) {
return 0;
}
-
``````````
</details>
https://github.com/llvm/llvm-project/pull/163510
More information about the libcxx-commits
mailing list