[libcxx-commits] [libcxx] [libc++] Fix {deque, vector}::append_range assuming too much about the types (PR #162438)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 9 06:41:28 PDT 2025


================
@@ -87,6 +87,11 @@ constexpr void for_all_iterators_and_allocators(Func f) {
     f.template operator()<Iter, sentinel_wrapper<Iter>, min_allocator<T>>();
     f.template operator()<Iter, sentinel_wrapper<Iter>, safe_allocator<T>>();
 
+    f.template operator()<Iter, sized_sentinel<Iter>, std::allocator<T>>();
----------------
ldionne wrote:

I wonder if this can have an adverse effect on our tests compile-time. Yes it increases coverage, but the only row in the cross product that we really want to test is `cpp20_input_iterator` with a `sized_sentinel`. Maybe we should do that instead (and let's add a comment explaining why we're cherry-picking that row).

https://github.com/llvm/llvm-project/pull/162438


More information about the libcxx-commits mailing list