[libcxx-commits] [libcxx] 981dadc - [libcxx] Map Windows ERROR_NETNAME_DELETED to no_such_file_or_directory (#162257)
via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Oct 7 12:32:11 PDT 2025
Author: Martin Storsjö
Date: 2025-10-07T22:32:07+03:00
New Revision: 981dadcd60481939bdc8917c6f15cb6232313bc1
URL: https://github.com/llvm/llvm-project/commit/981dadcd60481939bdc8917c6f15cb6232313bc1
DIFF: https://github.com/llvm/llvm-project/commit/981dadcd60481939bdc8917c6f15cb6232313bc1.diff
LOG: [libcxx] Map Windows ERROR_NETNAME_DELETED to no_such_file_or_directory (#162257)
This fixes spurious failures in
std/input.output/filesystems/fs.op.funcs/fs.op.proximate/proximate.pass.cpp
on Windows.
As part of that test, libcxx tries to open a fake network path such as
"//foo/a". Normally, this sets the error ERROR_BAD_NETPATH, which is
mapped to no_such_file_or_directory. However occasionally, it can end up
setting the error ERROR_NETNAME_DELETED instead.
Map ERROR_NETNAME_DELETED to no_such_file_or_directory just like
ERROR_BAD_NETPATH is mapped. This makes these cases be treated equally
within the create_file_status function in
src/filesystem/file_descriptor.h, causing the __weakly_canonical
function in operations.cpp to keep iterating, rather than erroring out.
Added:
Modified:
libcxx/src/system_error.cpp
Removed:
################################################################################
diff --git a/libcxx/src/system_error.cpp b/libcxx/src/system_error.cpp
index 164fb72621c17..6397a94932b63 100644
--- a/libcxx/src/system_error.cpp
+++ b/libcxx/src/system_error.cpp
@@ -95,6 +95,8 @@ std::optional<errc> __win_err_to_errc(int err) {
return errc::no_lock_available;
case ERROR_NEGATIVE_SEEK:
return errc::invalid_argument;
+ case ERROR_NETNAME_DELETED:
+ return errc::no_such_file_or_directory;
case ERROR_NOACCESS:
return errc::permission_denied;
case ERROR_NOT_ENOUGH_MEMORY:
More information about the libcxx-commits
mailing list