[libcxx-commits] [libcxx] Revert "[libc++] Avoid constructing additional objects when using map::at" (PR #160738)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> > Again, I don't think this is reasonable. I'm basically working on a different code base and know almost nothing about the backend. I don't even build that part of the monorepo.
> > All I'm asking here is for some communication what to actually do. Why is that so hard?
> 
> I think most of us assume that folks who are maintainers will be familiar w/ all this. I don't think anyone thought they weren't communicating something specific to you in the threads (I certainly thought things were clear, but obviously I misread the situation ... so sorry we didn't pick up on it earlier).
> 
> I don't think all the bots do this, but the sanitizer bots are pretty great, because they include reproducer instructions. If you look at the bottom of the log in the bot https://lab.llvm.org/buildbot/#/builders/169/builds/15293 theres a link to tell you what to do w/ a local llvm checkout https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild
> 
> TBH its pretty awesome that its so easy. IIRC some of the old build bots always used to give you a script to run that would do something similar, which would generally be appreciated, but IIRC all bots have the CMake invocation in their logs, so it shouldn't be too hard to reproduce, generally.
> 
> Hope that helps for next time :)

That's not what I'm asking for. I feel like you don't understand what you're asking for here. From my perspective, you're basically coming in and revert while asking me to fix a problem in a project I don't work on, and know very little about. I don't think you'd find it reasonable to go to libstdc++ and say "fix my build or I'll revert your patch". I fully understand that we're in the same repository and people are building the two projects together, and I'm fine with reverting patches temporarily to reduce friction, but that's not a reason for expecting that everybody is knowledgeable on every part of the project. I'm working on a standard library, not a compiler. All I'm asking for here is that someone familiar with the broken project owns the issue and works on a fix with me instead of saying "this broke things, good luck fixing it". I'm fine if it's not immediately clear who that person is, but I'd really appreciate _some_ effort to find someone.


https://github.com/llvm/llvm-project/pull/160738