[libcxx-commits] [libcxx] Revert "[libc++] Fix the locale base API on Linux with musl" (PR #169884)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 28 00:55:19 PST 2025


https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/169884

The patch has been committed without approval from the libc++ review group and is implementing the locale base API in a way it wasn't intended to be implemented. The commit also contains a no-reply github E-Mail, which is in conflict with the LLVM developer policy.

Reverts llvm/llvm-project#167980

>From 670ee5c2e8470f0558d0e03e84c1908359c68666 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser <nikolasklauser at berlin.de>
Date: Fri, 28 Nov 2025 09:51:56 +0100
Subject: [PATCH] Revert "[libc++] Fix the locale base API on Linux with musl
 (#167980)"

This reverts commit aa2a7f4eb1b130e9e41d9a87bffcaa47876a97fc.
---
 libcxx/include/__locale_dir/support/linux.h | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/libcxx/include/__locale_dir/support/linux.h b/libcxx/include/__locale_dir/support/linux.h
index deb657d4faced..1a589be49bf1d 100644
--- a/libcxx/include/__locale_dir/support/linux.h
+++ b/libcxx/include/__locale_dir/support/linux.h
@@ -83,30 +83,15 @@ inline _LIBCPP_HIDE_FROM_ABI __lconv_t* __localeconv(__locale_t& __loc) {
 // Strtonum functions
 //
 inline _LIBCPP_HIDE_FROM_ABI float __strtof(const char* __nptr, char** __endptr, __locale_t __loc) {
-#if !_LIBCPP_HAS_MUSL_LIBC || defined(_GNU_SOURCE)
   return ::strtof_l(__nptr, __endptr, __loc);
-#else
-  (void)__loc;
-  return ::strtof(__nptr, __endptr);
-#endif
 }
 
 inline _LIBCPP_HIDE_FROM_ABI double __strtod(const char* __nptr, char** __endptr, __locale_t __loc) {
-#if !_LIBCPP_HAS_MUSL_LIBC || defined(_GNU_SOURCE)
   return ::strtod_l(__nptr, __endptr, __loc);
-#else
-  (void)__loc;
-  return ::strtod(__nptr, __endptr);
-#endif
 }
 
 inline _LIBCPP_HIDE_FROM_ABI long double __strtold(const char* __nptr, char** __endptr, __locale_t __loc) {
-#if !_LIBCPP_HAS_MUSL_LIBC || defined(_GNU_SOURCE)
   return ::strtold_l(__nptr, __endptr, __loc);
-#else
-  (void)__loc;
-  return ::strtold(__nptr, __endptr);
-#endif
 }
 
 //



More information about the libcxx-commits mailing list