[libcxx-commits] [libcxx] [libc++] Fix the locale base API on Linux with musl (PR #167980)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 28 00:52:00 PST 2025


philnik777 wrote:

@hstk30-hw libc++ patches require approval from @llvm/reviewers-libcxx. Please wait to merge until someone in that group has approved. More generally re. the patch, this is not how the locale base API is supposed to be implemented. Instead, a separate file should be added for musl in `__locale_dir/support/linux.h` which implements this for musl. Lastly, why do we check for `defined(_GNU_SOURCE)`? If we can get the `_l` variants, why do we not do that unconditionally? Given this, I'll revert.

P.S. this commit violated https://llvm.org/docs/DeveloperPolicy.html#github-email-address

https://github.com/llvm/llvm-project/pull/167980


More information about the libcxx-commits mailing list