[libcxx-commits] [libcxx] [libc++] Optimize basic_string::append(Iter, Iter) (PR #169794)

via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 27 04:15:46 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions ,cpp -- libcxx/include/string libcxx/test/benchmarks/containers/string.bench.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/test/benchmarks/containers/string.bench.cpp b/libcxx/test/benchmarks/containers/string.bench.cpp
index 6408b2312..595275217 100644
--- a/libcxx/test/benchmarks/containers/string.bench.cpp
+++ b/libcxx/test/benchmarks/containers/string.bench.cpp
@@ -128,7 +128,7 @@ BENCHMARK(BM_StringResizeAndOverwrite);
 template <class Container>
 static void BM_StringAppend(benchmark::State& state) {
   std::string orig_str = "This is some data so the string isn't empty";
-  std::string str = orig_str;
+  std::string str      = orig_str;
 
   const char to_append_str[] = "This is a long string to make sure append does some work";
   Container to_append;

``````````

</details>


https://github.com/llvm/llvm-project/pull/169794


More information about the libcxx-commits mailing list