[libcxx-commits] [libcxx] [libcxxabi] [libc++][NFC] Move __memory/aligned_alloc.h into src/ (PR #166172)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> A different question about the same file: We're instead seeing:
> 
> ```
> [1285/98564] CXX obj/buildtools/third_party/libc++abi/libc++abi/fallback_malloc.o
> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/buildtools/third_party/libc++abi/libc++abi/fallback_malloc.o.d -DLIBCXXA...(too long)
> ../../third_party/libc++abi/src/src/fallback_malloc.cpp:19:10: fatal error: '__memory/aligned_alloc.h' file not found
>    19 | #include <__memory/aligned_alloc.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> ```
> 
> The PR description says "This header is only ever used inside src/". I suppose libcxxabi/src is also inside src/ – is libcxx/src supposed to be on libcxxabi's include search path?

Yes, it's very unfortunate. This is yet another reason libc++abi should be merged into libc++.

https://github.com/llvm/llvm-project/pull/166172