[libcxx-commits] [libcxx] [libc++][memory] Applied `[[nodiscard]]` to smart pointers (PR #168483)

[Nico Weber via libcxx-commits]

nico wrote:

Here's two more that just test that a create/destroy sequence doesn't crash (not as a death test):
https://chromium-review.googlesource.com/c/chromium/src/+/7198792/11/chrome/browser/ash/notifications/idle_app_name_notification_view_unittest.cc
https://chromium-review.googlesource.com/c/chromium/src/+/7198792/11/chromeos/ash/services/secure_channel/ble_characteristics_finder_unittest.cc

For the one I wanted to look into, it also looks like the make_unique<> result was intentionally not used, but the code is a bit convoluted: http://crbug.com/463698813

So for us it's 9/9 false positives.

(But, again, no action needed, just contributing a data point.)

https://github.com/llvm/llvm-project/pull/168483