https://github.com/huixie90 commented: Thanks a lot ! It looks good to me once my new comments are addressed and CI is green. I will leave final approval to Nicolas as he also has some open comments https://github.com/llvm/llvm-project/pull/165096