[libcxx-commits] [libcxx] [llvm] [LIT] remove `to_unicode`, `to_string`, and `to_bytes` helpers (PR #165950)

[Tomohiro Kashiwada via libcxx-commits]

================
@@ -1394,8 +1376,6 @@ def executeScript(test, litConfig, tmpBase, commands, cwd):
                 # seen the latter manage to terminate the shell running lit.
                 if command:
                     commands[i] += f" && {{ {command}; }}"
-        if test.config.pipefail:
----------------
kikairoya wrote:

It was moved to minimize the lifetime of `f`.
I think the order of operations -- open, build the contents, write, close -- is better than open, build the contents, write, close.

https://github.com/llvm/llvm-project/pull/165950