[libcxx-commits] [libcxx] [libc++] Do not call in flat containers if underlying container is user defined (PR #140379)

via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 17 08:30:59 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,,cpp -- libcxx/include/__flat_map/flat_map.h libcxx/include/__flat_map/flat_multimap.h libcxx/include/__flat_set/flat_multiset.h libcxx/include/__flat_set/flat_set.h libcxx/include/__type_traits/container_traits.h libcxx/include/__vector/container_traits.h libcxx/include/deque libcxx/include/forward_list libcxx/include/list libcxx/include/map libcxx/include/set libcxx/include/unordered_map libcxx/include/unordered_set libcxx/test/std/containers/container.adaptors/flat.map/flat.map.modifiers/insert_iter_iter.pass.cpp libcxx/test/std/containers/container.adaptors/flat.multimap/flat.multimap.modifiers/insert_iter_iter.pass.cpp libcxx/test/std/containers/container.adaptors/flat.multiset/flat.multiset.modifiers/insert_iter_iter.pass.cpp libcxx/test/std/containers/container.adaptors/flat.set/flat.set.modifiers/insert_iter_iter.pass.cpp libcxx/test/std/containers/container.adaptors/flat_helpers.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/test/std/containers/container.adaptors/flat_helpers.h b/libcxx/test/std/containers/container.adaptors/flat_helpers.h
index 458ad24e4..19d637052 100644
--- a/libcxx/test/std/containers/container.adaptors/flat_helpers.h
+++ b/libcxx/test/std/containers/container.adaptors/flat_helpers.h
@@ -29,9 +29,7 @@ template <class T>
 struct SillyReserveVector : std::vector<T> {
   using std::vector<T>::vector;
 
-  void reserve(size_t ) {
-    this->clear();
-  }
+  void reserve(size_t) { this->clear(); }
 };
 
 template <class T, bool ConvertibleToT = false>

``````````

</details>


https://github.com/llvm/llvm-project/pull/140379


More information about the libcxx-commits mailing list