https://github.com/ldionne commented: This looks pretty good, thanks! There are some comments to address from me and from Nikolas, but after that I think this should be good to go! https://github.com/llvm/llvm-project/pull/128832