[libcxx-commits] [libcxx] [libcxxabi] [libc++] Fix localization failures on macOS 15.4 (PR #138744)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 8 13:32:23 PDT 2025


ldionne wrote:

@mordante I should be nearly done with fixing these issues. The last ones are related to the Japanese locale and I'm not certain whether the changes in macOS 15.4 are correct or not.

I'd like to bring up a meta point though, which is that these tests are a total mess to keep working on various platforms. For example this patch fixes issues on macOS 15.4, but if you're running the test suite on e.g. macOS 15.1, you'll get failures that are effectively the inverse of this patch. I'm not certain how we want to proceed in the general case, but it seems like we should have at least some sort of policy. FWIW I don't think that making these tests work with all platforms at all times is realistic, unless we want to do some serious refactoring of these tests (and I'd question the value of that).

https://github.com/llvm/llvm-project/pull/138744


More information about the libcxx-commits mailing list