[libcxx-commits] [libcxxabi] [llvm] [ItaniumDemangle][test] Turn ItaniumDemangle tests into LLVM unit-tests (PR #137947)

[Michael Buch via libcxx-commits]

Michael137 wrote:

> I don't think it makes sense to _remove_ this test coverage from libc++abi, since it really weakens the tests for libc++abi. Instead, would it make sense to do what you're doing here and store the test cases in a text file, and then load that from both the LLVM tests and from the libc++abi tests? That way both can keep the full coverage yet there is a single source of truth for these test cases.

Yea that should work. Are you suggesting we put the test-cases in `libcxxabi/test/` next to `test_demangle.pass.cpp` and then adjust the `cp-to-llvm.sh` script to sync that file into the LLVM repo? Or should this file be distributed like other headers and LLVM would just reach into libcxxabi to include this file? From LLDB's perspective I would prefer the former, because libcxxabi isn't always a requirement to run the LLDB tests. So if we could have the file synced into LLVM that would work for us.

Also, if we have the tests in both `test_demangle.pass.cpp` *and* LLVM, what should we do with the test-cases that test invalid inputs and floating point inputs. Those are currently separate test-cases in `test_demangle.pass.cpp`. Should we keep them in one place only? Or also factor out the test-cases into separate files and have tests for them in libc++abi *and* LLVM?

https://github.com/llvm/llvm-project/pull/137947