[libcxx-commits] [libcxx] [libc++] Add _LIBCPP_NO_UNIQUE_ADDRESS to flat_{, multi}map::value_compare (PR #137594)

via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 3 01:22:42 PDT 2025


https://github.com/huixie90 approved this pull request.

I agree this is very unlikely to break anything, because `value_compare` is not stored in `flat_map`. The only situation this can break anything is when user do `m.value_compare()` and then store the results in a struct.

Could we add a unittest in libcxx folder?

Otherwise LGTM


https://github.com/llvm/llvm-project/pull/137594


More information about the libcxx-commits mailing list