[libcxx-commits] [libcxx] [libc++] Remove _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS and _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS (PR #133704)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 31 04:31:11 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions ,cpp,h -- libcxx/include/__config libcxx/include/__locale libcxx/include/__ostream/basic_ostream.h libcxx/include/fstream libcxx/include/ios libcxx/include/istream libcxx/include/locale libcxx/include/sstream libcxx/include/streambuf libcxx/src/ios.instantiations.cpp libcxx/src/locale.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/include/__config b/libcxx/include/__config
index be96aaac5..066798adb 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -541,8 +541,8 @@ typedef __char32_t char32_t;
 #  endif
 
 #  if __has_warning("-Wdllexport-explicit-instantiation")
-#      define _LIBCPP_CLANG_DIAGNOSTIC_IGNORE_DLLEXPORT                                                                \
-        _LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wdllexport-explicit-instantiation")
+#    define _LIBCPP_CLANG_DIAGNOSTIC_IGNORE_DLLEXPORT                                                                  \
+      _LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wdllexport-explicit-instantiation")
 #  elif defined(_LIBCPP_OBJECT_FORMAT_COFF)
 #    define _LIBCPP_CLANG_DIAGNOSTIC_IGNORE_DLLEXPORT                                                                  \
       _LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wignored-attributes")                                                         \
diff --git a/libcxx/src/locale.cpp b/libcxx/src/locale.cpp
index 88430119f..b6f10ca4c 100644
--- a/libcxx/src/locale.cpp
+++ b/libcxx/src/locale.cpp
@@ -5716,12 +5716,9 @@ template class _LIBCPP_EXPORTED_FROM_ABI messages_byname<char>;
 _LIBCPP_IF_WIDE_CHARACTERS(template class _LIBCPP_EXPORTED_FROM_ABI messages_byname<wchar_t>;)
 
 template class _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<char, char, mbstate_t>;
-_LIBCPP_IF_WIDE_CHARACTERS(
-    template class _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<wchar_t, char, mbstate_t>;)
-template class _LIBCPP_DEPRECATED_IN_CXX20 _LIBCPP_EXPORTED_FROM_ABI
-    codecvt_byname<char16_t, char, mbstate_t>;
-template class _LIBCPP_DEPRECATED_IN_CXX20 _LIBCPP_EXPORTED_FROM_ABI
-    codecvt_byname<char32_t, char, mbstate_t>;
+_LIBCPP_IF_WIDE_CHARACTERS(template class _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<wchar_t, char, mbstate_t>;)
+template class _LIBCPP_DEPRECATED_IN_CXX20 _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<char16_t, char, mbstate_t>;
+template class _LIBCPP_DEPRECATED_IN_CXX20 _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<char32_t, char, mbstate_t>;
 #if _LIBCPP_HAS_CHAR8_T
 template class _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<char16_t, char8_t, mbstate_t>;
 template class _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<char32_t, char8_t, mbstate_t>;

``````````

</details>


https://github.com/llvm/llvm-project/pull/133704


More information about the libcxx-commits mailing list