[libcxx-commits] [libcxx] [libc++] Guard additional headers with _LIBCPP_HAS_LOCALIZATION (PR #131921)

[Louis Dionne via libcxx-commits]

ldionne wrote:

> Currently the tests do have explicit -include <picolibc.h> in their commandline, but they link against the prebuilt specializations (libcxx/src/ios.instantiations.cpp), which have been compiled in the library build step (not test build step) and at that step the flag was not added. (At least this is how I think it works).

Ah, yes, that makes sense!

> detect picolibc during cmake configure step and record this in __config_site

That's what I want to do indeed. I think you have very good suggestions in fact, I'll think about it further.

For the meantime, I'll go ahead and try that fix to unblock this patch landing. I think `<picolibc.h>` is a sufficiently rare name that it shouldn't conflict with many headers named the same in existing projects. Thanks a lot for your input.

https://github.com/llvm/llvm-project/pull/131921