[libcxx-commits] [libcxx] [libc++][test] Small fixes for time tests (PR #132532)

A. Jiang via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 22 00:31:52 PDT 2025


================
@@ -36,11 +36,11 @@
 #include "test_macros.h"
 
 // class gps_clock
-using rep                = std::chrono::gps_clock::rep;
-using period             = std::chrono::gps_clock::period;
-using duration           = std::chrono::gps_clock::duration;
-using time_point         = std::chrono::gps_clock::time_point;
-constexpr bool is_steady = std::chrono::gps_clock::is_steady;
+using rep                                 = std::chrono::gps_clock::rep;
+using period                              = std::chrono::gps_clock::period;
+using duration                            = std::chrono::gps_clock::duration;
+using time_point                          = std::chrono::gps_clock::time_point;
+[[maybe_unused]] constexpr bool is_steady = std::chrono::gps_clock::is_steady;
----------------
frederick-vs-ja wrote:

As the `is_steady` is tested only once (ditto `tai_clock::is_steady`) and doesn't seem necessary for twice, should we just remove it and write `LIBCPP_STATIC_ASSERT(std::chrono::gps_clock::is_steady == false);` instead?
CC @mordante.

https://github.com/llvm/llvm-project/pull/132532


More information about the libcxx-commits mailing list