[libcxx-commits] [libcxx] [libc++][test] Fix issues found by MSVC's STL (PR #131787)
Stephan T. Lavavej via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 20 14:05:48 PDT 2025
================
@@ -14,7 +14,8 @@
// the insertion point remain valid but those at or after the insertion point,
// including the past-the-end iterator, are invalidated.
-// REQUIRES: has-unix-headers, libcpp-has-abi-bounded-iterators-in-vector
+// REQUIRES: has-unix-headers
+// REQUIRES: libcpp-has-abi-bounded-iterators-in-vector
----------------
StephanTLavavej wrote:
Thanks, understood. Most of the multi-requirements pose no issue for our internal test harness - it's just the ones that cause MSVC skips, like `REQUIRES: has-unix-headers` or `XFAIL: msvc`, and there haven't been a lot of those being introduced or changed. If this becomes more common or disruptive for you, we can add skips on our side, or figure out how to make the internal test harness parser smarter. (We may need to do that for `ADDITIONAL_COMPILE_FLAGS`, which currently it doesn't understand at all.)
https://github.com/llvm/llvm-project/pull/131787
More information about the libcxx-commits
mailing list