[libcxx-commits] [libcxx] [libcxx][clang-modules] Fix headers being marked as textual (PR #130723)

[Ian Anderson via libcxx-commits]

ian-twilightcoder wrote:

> > None of these should be `textual` because they have declarations, which becomes a problem because their declarations build into all of their (transitive) includers' modules.
> 
> @ian-twilightcoder Correction, they don't contain declarations -- macros only. That may not change the fact that these shouldn't be textual, but I still wanted to clarify.

Macros count as declarations, at least in the pcm/ast sense.

> There's a few places where you folks mentioned "explicit" modules -- what do you mean by that? Do you mean just Clang's `-fmodules` flag, or something else? I usually hear `-fmodules` referred to as "just Clang Modules", and I wonder if "explicit" modules is something else I should pay attention to?

Presumably that means `-fno-implicit-module-maps`, described a bit at https://developer.apple.com/documentation/xcode/building-your-project-with-explicit-module-dependencies

https://github.com/llvm/llvm-project/pull/130723