[libcxx-commits] [libcxx] [libc++] Add benchmarks for is_permutation and its std::ranges counte… (PR #130387)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne requested changes to this pull request.

Thanks for the patch! Unfortunately it looks like we raced a bit here, I already had https://github.com/llvm/llvm-project/pull/128206 up which added similar benchmarks for `{std,ranges}::is_permutation`.

I had a look to make sure that both had similar coverage and I think that's the case. You do have different benchmarks for the following cases
- both sequences are identical
- both sequences differ only in the last element

However, I don't think the performance profile of the algorithm would change much between those two -- it would only change whether the answer is `true` or `false`. Therefore, I think the benchmarks for `is_permutation` I checked in recently probably supersede the ones added in this PR.

I am happy to work with you on getting https://github.com/llvm/llvm-project/pull/129565 reviewed, though.

https://github.com/llvm/llvm-project/pull/130387