[libcxx-commits] [libcxx] [libc++][test] Fix issues found by MSVC's STL (PR #131787)

Stephan T. Lavavej via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 18 13:50:32 PDT 2025


================
@@ -71,7 +71,7 @@ TEST_CONSTEXPR_CXX20 bool tests() {
   // Test with various allocators and different `size_type`s
   {
     test(std::vector<bool>());
-    test(std::vector<bool, std::allocator<int> >());
+    test(std::vector<bool, std::allocator<bool> >());
----------------
StephanTLavavej wrote:

Thanks! I have submitted an LWG issue via email: "Does `vector<bool, Allocator>` mandate that `Allocator::value_type` is `bool`?"

I would prefer to keep my change to use `allocator<bool>` here. If the LWG issue is resolved in favor of creating an exemption, then MSVC's STL will need to be updated, and I believe that a separate libc++ test to exercise `vector<bool, allocator<Anything>>` should be added (instead of mixing this in to the `max_size` test).

https://github.com/llvm/llvm-project/pull/131787


More information about the libcxx-commits mailing list