[libcxx-commits] [libcxx] [libc++][test] Fix issues found by MSVC's STL (PR #131787)
Stephan T. Lavavej via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Mar 18 12:57:44 PDT 2025
================
@@ -71,7 +71,7 @@ TEST_CONSTEXPR_CXX20 bool tests() {
// Test with various allocators and different `size_type`s
{
test(std::vector<bool>());
- test(std::vector<bool, std::allocator<int> >());
+ test(std::vector<bool, std::allocator<bool> >());
----------------
StephanTLavavej wrote:
Sure, I agree that `allocator_traits::construct` is a difference here, and that `vector<bool>` is weird and inconsistent. I don't think that this creates an exception to the Mandates, though. An LWG issue to clearly decide one way or the other could be useful.
Should I undo this change, which will require me to knownfail this `max_size` test for MSVC's STL?
https://github.com/llvm/llvm-project/pull/131787
More information about the libcxx-commits
mailing list