[libcxx-commits] [libcxx] [libc++][test] Fix issues found by MSVC's STL (PR #131787)

Stephan T. Lavavej via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 18 12:16:54 PDT 2025


================
@@ -71,7 +71,7 @@ TEST_CONSTEXPR_CXX20 bool tests() {
   // Test with various allocators and different `size_type`s
   {
     test(std::vector<bool>());
-    test(std::vector<bool, std::allocator<int> >());
+    test(std::vector<bool, std::allocator<bool> >());
----------------
StephanTLavavej wrote:

Every other `vector<T>` requires that it's given an allocator for `T`, so allowing `vector<bool>` to vary doesn't seem useful to users.

What the container actually does with the allocator is IMO not very important for the requirements placed on users. For example, `list<T>` uses its allocator to allocate an internal node type.

https://github.com/llvm/llvm-project/pull/131787


More information about the libcxx-commits mailing list