[libcxx-commits] [libcxx] [libc++] Optimize num_put integral functions (PR #120859)

[Louis Dionne via libcxx-commits]

ldionne wrote:

Thanks a lot for the investigation. I filed https://github.com/llvm/llvm-project/issues/131710 for @philnik777 to take a look at this again when he's back from vacation.

FWIW I'm not surprised that our tests in this area were not 100% sufficient: we talked about it during the review but I'm not very surprised that something was missed, since this is a very widely used API. During review we had discussed testing against other implementations as well but I think this wasn't followed through -- when we re-land this we should try to also increase coverage.

https://github.com/llvm/llvm-project/pull/120859