[libcxx-commits] [libcxx] [libcxx] Export the formatter_integral for module build. (PR #131778)
via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Mar 18 03:49:59 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Haojian Wu (hokein)
<details>
<summary>Changes</summary>
Chromium encounters another similar issue, https://crbug.com/400870610
Workaround #<!-- -->120108.
---
Full diff: https://github.com/llvm/llvm-project/pull/131778.diff
1 Files Affected:
- (modified) libcxx/include/module.modulemap (+8-2)
``````````diff
diff --git a/libcxx/include/module.modulemap b/libcxx/include/module.modulemap
index 43072aa0fb0f1..1dc1dc845cafd 100644
--- a/libcxx/include/module.modulemap
+++ b/libcxx/include/module.modulemap
@@ -926,7 +926,10 @@ module std [system] {
module to_chars { header "__charconv/to_chars.h" }
module to_chars_base_10 { header "__charconv/to_chars_base_10.h" }
module to_chars_floating_point { header "__charconv/to_chars_floating_point.h" }
- module to_chars_integral { header "__charconv/to_chars_integral.h" }
+ module to_chars_integral {
+ header "__charconv/to_chars_integral.h"
+ export * // TODO: Workaround for https://github.com/llvm/llvm-project/issues/120108
+ }
module to_chars_result { header "__charconv/to_chars_result.h" }
module traits { header "__charconv/traits.h" }
@@ -1316,7 +1319,10 @@ module std [system] {
module formatter_char { header "__format/formatter_char.h" }
module formatter_floating_point { header "__format/formatter_floating_point.h" }
module formatter_integer { header "__format/formatter_integer.h" }
- module formatter_integral { header "__format/formatter_integral.h" }
+ module formatter_integral {
+ header "__format/formatter_integral.h"
+ export * // TODO: Workaround for https://github.com/llvm/llvm-project/issues/120108
+ }
module formatter_output { header "__format/formatter_output.h" }
module formatter_pointer { header "__format/formatter_pointer.h" }
module formatter_string { header "__format/formatter_string.h" }
``````````
</details>
https://github.com/llvm/llvm-project/pull/131778
More information about the libcxx-commits
mailing list