[libcxx-commits] [libcxx] [libc++] Implement part of P2562R1: constexpr `std::inplace_merge` (PR #129008)

[Mark de Wever via libcxx-commits]

================
@@ -0,0 +1,705 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef TEST_SUPPORT_CONSTEXPR_RANDOM_H
+#define TEST_SUPPORT_CONSTEXPR_RANDOM_H
----------------
mordante wrote:

I feel this is quite a lot of code. I know we've had bugs in libc++ with Schrage's algorithm. So I'm a bit reluctant to add this code without any tests; probably in a separate commit. I still wonder whether we shouldn't add a simplified random algorithm. Not only to keep the code simple, but also to keep the number of steps during constant evaluation lower. WDYT?

https://github.com/llvm/llvm-project/pull/129008