[libcxx-commits] [libcxx] [libc++] Add `-Watomic-memory-ordering` diagnostic tests for `atomic_ref` (PR #130206)

Damien L-G via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 7 04:10:38 PST 2025


================

----------------
dalg24 wrote:

Sorry I should have highlighted it.
Here is what changed
```diff
--- before	2025-03-07 07:03:22
+++ after	2025-03-07 07:02:50
@@ -1,9 +1,14 @@
 libcxx/test/libcxx/atomics/atomics.ref
-├── assert.compare_exchange_strong.pass.cpp
-├── assert.compare_exchange_weak.pass.cpp
-├── assert.ctor.pass.cpp
-├── assert.load.pass.cpp
-├── assert.store.pass.cpp
-├── assert.wait.pass.cpp
+├── compare_exchange_strong.pass.cpp
+├── compare_exchange_strong.verify.cpp
+├── compare_exchange_weak.pass.cpp
+├── compare_exchange_weak.verify.cpp
+├── ctor.pass.cpp
+├── load.pass.cpp
+├── load.verify.cpp
+├── store.pass.cpp
+├── store.verify.cpp
+├── wait.pass.cpp
+└── wait.verify.cpp

 1 directory, 11 files
```
I was wondering how I should name the tests I was adding and I looked at https://libcxx.llvm.org/TestingLibcxx.html#test-names which I interpreted as the names for the pre-existing file names is wrong.  So I removed the `assert.` prefix in a preliminary commit and thought it is "loosely" related.

That said, I am happy to withdraw the file renaming changes.  Just let me know what you would like me to do.

https://github.com/llvm/llvm-project/pull/130206


More information about the libcxx-commits mailing list