[libcxx-commits] [libcxx] [libc++] Fix insert() calling incorrect constructors (PR #146231)

[via libcxx-commits]

EricWF wrote:

> > Are you at all concerned by the removal of the optimizations here?
> > Could we add some tests to establish exactly how much performance is being lost?
> 
> Could you elaborate which optimizations you are talking about? AFAICT `__emplace_unique` does the same unwrapping `__insert_unique` does (though, granted, with a bit more metaprogramming trickery).

You're right. I misread the diff. 

https://github.com/llvm/llvm-project/pull/146231