[libcxx-commits] [libcxx] [libc++] Disable isw*_l functions on old MSVCRT (< 0x800) (PR #144273)

[Martin Storsjö via libcxx-commits]

mstorsjo wrote:

> I'm really not convinced we want to support such old systems. Windows 7 has been EoL since 2020.

FWIW, current libc++ does work fine on Windows 7, with mingw-w64 headers/libs (I just rechecked with a fresh nightly build); although mingw-w64 may have a little bit of compatibility glue code around these locale functions for msvcrt.dll in there (see commits as https://github.com/mingw-w64/mingw-w64/commit/797b4a6b51916d3d1c934d80a7b3d1725099f325, https://github.com/mingw-w64/mingw-w64/commit/87558c151f0a447d8f00af1a7d3a88a273aa8c23, https://github.com/mingw-w64/mingw-w64/commit/16ad1d4e426becb19ece4cfa90f33e7d7cd96e53). For patches like this, it would be good to know which SDK setup it is about - I presume this is for use with ReactOS?

As the mingw configuration still does work, I'm also a bit hesitant about accepting this change.

https://github.com/llvm/llvm-project/pull/144273