[libcxx-commits] [libcxx] 0905767 - [libc++] Address remaining comments from #130145

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 26 03:35:30 PDT 2025


Author: Nikolas Klauser
Date: 2025-06-26T12:34:19+02:00
New Revision: 0905767610d656fdbe98094583b3d5f5be5f29da

URL: https://github.com/llvm/llvm-project/commit/0905767610d656fdbe98094583b3d5f5be5f29da
DIFF: https://github.com/llvm/llvm-project/commit/0905767610d656fdbe98094583b3d5f5be5f29da.diff

LOG: [libc++] Address remaining comments from #130145

I've accidentally merged the PR before addressing all
comments. This patch fixes the remaining ones.

Added: 
    

Modified: 
    libcxx/test/std/thread/futures/futures.async/wait_on_destruct.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/thread/futures/futures.async/wait_on_destruct.pass.cpp b/libcxx/test/std/thread/futures/futures.async/wait_on_destruct.pass.cpp
index 984fcd316b591..8260ec3dfcaf4 100644
--- a/libcxx/test/std/thread/futures/futures.async/wait_on_destruct.pass.cpp
+++ b/libcxx/test/std/thread/futures/futures.async/wait_on_destruct.pass.cpp
@@ -15,13 +15,15 @@
 // Make sure that the `future` destructor keeps the data alive until the thread finished. This test fails by triggering
 // TSan. It may not be observable by normal means.
 
+// See https://github.com/llvm/llvm-project/pull/125433#issuecomment-2703618927 for more details.
+
 #include <atomic>
 #include <future>
 #include <mutex>
 
 std::mutex mux;
 
-int main() {
+int main(int, char**) {
   using namespace std::chrono_literals;
   std::unique_lock lock(mux);
   std::atomic<bool> in_async = false;
@@ -34,4 +36,6 @@ int main() {
   });
   in_async.wait(true);
   lock.unlock();
+
+  return 0;
 }


        


More information about the libcxx-commits mailing list