[libcxx-commits] [libcxx] [libc++] P2944R3: Constrained comparisions - `optional` (PR #144249)

[via libcxx-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions ,h,cpp -- libcxx/include/__type_traits/is_core_convertible.h libcxx/include/optional libcxx/test/std/utilities/optional/optional.comp_with_t/equal.pass.cpp libcxx/test/std/utilities/optional/optional.comp_with_t/greater.pass.cpp libcxx/test/std/utilities/optional/optional.comp_with_t/greater_equal.pass.cpp libcxx/test/std/utilities/optional/optional.comp_with_t/less_equal.pass.cpp libcxx/test/std/utilities/optional/optional.comp_with_t/less_than.pass.cpp libcxx/test/std/utilities/optional/optional.comp_with_t/not_equal.pass.cpp libcxx/test/std/utilities/optional/optional.relops/equal.pass.cpp libcxx/test/std/utilities/optional/optional.relops/greater_equal.pass.cpp libcxx/test/std/utilities/optional/optional.relops/greater_than.pass.cpp libcxx/test/std/utilities/optional/optional.relops/less_equal.pass.cpp libcxx/test/std/utilities/optional/optional.relops/less_than.pass.cpp libcxx/test/std/utilities/optional/optional.relops/not_equal.pass.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/include/optional b/libcxx/include/optional
index b030ca1e3..2345dcf4d 100644
--- a/libcxx/include/optional
+++ b/libcxx/include/optional
@@ -999,7 +999,8 @@ _LIBCPP_HIDE_FROM_ABI constexpr bool operator==(const optional<_Tp>& __x, const
 
 template < class _Tp,
            class _Up,
-           enable_if_t<__is_convertible_to_bool_v<decltype(std::declval<const _Tp&>() != std::declval<const _Up&>())>, int> = 0>
+           enable_if_t<__is_convertible_to_bool_v<decltype(std::declval<const _Tp&>() != std::declval<const _Up&>())>,
+                       int> = 0>
 _LIBCPP_HIDE_FROM_ABI constexpr bool operator!=(const optional<_Tp>& __x, const optional<_Up>& __y) {
   if (static_cast<bool>(__x) != static_cast<bool>(__y))
     return true;

``````````

</details>


https://github.com/llvm/llvm-project/pull/144249