[libcxx-commits] [libcxx] 7157f33 - [libc++] Disable a std::unexpected test in modules build (#144466)
via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Jun 20 09:59:02 PDT 2025
Author: Aiden Grossman
Date: 2025-06-20T12:58:59-04:00
New Revision: 7157f33c6c88143acb8bc02bc26a0d6786136419
URL: https://github.com/llvm/llvm-project/commit/7157f33c6c88143acb8bc02bc26a0d6786136419
DIFF: https://github.com/llvm/llvm-project/commit/7157f33c6c88143acb8bc02bc26a0d6786136419.diff
LOG: [libc++] Disable a std::unexpected test in modules build (#144466)
This patch disables unexpected_disabled_cpp17.verify.cpp under clang
modules builds because it changes diagnostics criteria post #143423,
causing the test to fail.
This patch follows a similar style to 853059a15011fd8b57dd0.
This was found when working on trying to land #144033.
Added:
Modified:
libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
Removed:
################################################################################
diff --git a/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp b/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
index 299cb123fbda3..b92f2baa02e47 100644
--- a/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
+++ b/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
@@ -8,6 +8,11 @@
// UNSUPPORTED: c++03, c++11, c++14
+// When built with modules, this test gives diagnostics like declaration of
+// 'unexpected' must be imported from module 'std.expected.unexpected' before
+// it is required. Therefore disable it in this configuration.
+// UNSUPPORTED: clang-modules-build
+
// test unexpected
#include <exception>
More information about the libcxx-commits
mailing list